fix(common): Synchronize file to disk in NativeIO
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2024
clabby
force-pushed
the
cl/oracle-blob-fetcher
branch
from
cc2c125 to
27b9970
Compare
clabby
force-pushed
the
cl/host-sync-fixes
branch
2 times, most recently
from
f8f9794 to
2dab14e
Compare
clabby
force-pushed
the
cl/oracle-blob-fetcher
branch
from
27b9970 to
fd50500
Compare
clabby
force-pushed
the
cl/host-sync-fixes
branch
from
2dab14e to
87e28c3
Compare
|
Just a note, this is a dud. Changed upstack. |
refcell
approved these changes
Jun 16, 2024
clabby
force-pushed
the
cl/oracle-blob-fetcher
branch
from
fd50500 to
18d7194
Compare
clabby
force-pushed
the
cl/host-sync-fixes
branch
from
87e28c3 to
1acce4d
Compare
Fixes a rare synchronization error in the `NativeIO`, where when fetching is happening very fast concurrently, the file's contents may not be synced to disk fast enough for the other end of the pipe to recognize.
clabby
force-pushed
the
cl/oracle-blob-fetcher
branch
from
18d7194 to
877f22e
Compare
clabby
force-pushed
the
cl/host-sync-fixes
branch
from
1acce4d to
03d3283
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a rare synchronization error in the
NativeIO, where when fetching is happening very fast concurrently, the file's contents may not be synced to disk fast enough for the other end of the pipe to recognize. Notably,std::fs::Filedoes not block on updating the metadata of the file to disk when it is being dropped.File::sync_alldoes exactly this, blocking until all metadata and in-memory contents have been flushed to disk.