Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(primitives): rm RawTransaction #505

Merged
merged 3 commits into from
Sep 7, 2024
Merged

chore(primitives): rm RawTransaction #505

merged 3 commits into from
Sep 7, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Sep 6, 2024

Description

Removes the RawTransaction type from kona-primitives, using alloy_primitives::Bytes in-place.

Closes #500

Copy link
Collaborator Author

refcell commented Sep 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title chore(primitives): Remove the RawTransaction type chore(primitives): rm RawTransaction Sep 6, 2024
@refcell refcell requested a review from clabby September 6, 2024 12:54
@refcell refcell added A-primitives K-chore Kind: chore labels Sep 6, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review September 6, 2024 12:54
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.2%. Comparing base (829b674) to head (61e7e33).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/derive/src/batch/single_batch.rs 66.6% 1 Missing ⚠️
crates/derive/src/batch/span_batch/transactions.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/derive/src/batch/single_batch.rs Outdated Show resolved Hide resolved
@refcell refcell added this pull request to the merge queue Sep 7, 2024
Merged via the queue into main with commit b6d6db6 Sep 7, 2024
16 checks passed
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
This was referenced Sep 21, 2024
This was referenced Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(primitives): Remove RawTransaction
2 participants