Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove L2 Execution Payload #542

Merged
merged 5 commits into from
Sep 23, 2024
Merged

feat: Remove L2 Execution Payload #542

merged 5 commits into from
Sep 23, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Sep 20, 2024

Description

Removes the L2ExecutionPayload type, changing the L2ChainProvider trait to return OpBlock by number instead of payload by number. This type was effectively just used as an intermediate type to convert between raw block from debug_getRawBlock and transactions, l2 block ref, and system config used to validate span batches.

Closes #517

Copy link
Collaborator Author

refcell commented Sep 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title feat: remove l2 execution payload feat: Remove L2 Execution Payload Sep 20, 2024
@refcell refcell requested a review from clabby September 20, 2024 22:19
@refcell refcell added A-derive Area: kona-derive crate A-primitives K-feature Kind: feature labels Sep 20, 2024 — with Graphite App
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 46.20690% with 78 lines in your changes missing coverage. Please review.

Project coverage is 78.4%. Comparing base (7f744d1) to head (f10ab28).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/block.rs 27.8% 57 Missing ⚠️
crates/derive/src/online/alloy_providers.rs 0.0% 16 Missing ⚠️
crates/derive/src/batch/span_batch/batch.rs 86.9% 3 Missing ⚠️
crates/derive/src/traits/test_utils.rs 66.6% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell marked this pull request as ready for review September 20, 2024 22:19
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch looks great to me at a high-level. Looks like there are a few tests that are failing, though. Glad to send through once CI is green :)

@refcell refcell self-assigned this Sep 23, 2024
@refcell refcell requested a review from clabby September 23, 2024 14:34
@refcell refcell added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 3050746 Sep 23, 2024
16 of 17 checks passed
This was referenced Sep 23, 2024
github-merge-queue bot pushed a commit to alloy-rs/op-alloy that referenced this pull request Oct 1, 2024
### Description

Removes payload conversion utilities.

Kona removed the need to fetch the payload by number, using the block
instead in op-rs/kona#542.

Instead of converting a payload into the `L2BlockInfo` and
`SystemConfig`, the `OpBlock` type is now fetched and converted into
those types using the conversion utilities:
-
[`L2BlockInfo::from_block_and_genesis`](https://github.com/alloy-rs/op-alloy/blob/main/crates/protocol/src/block.rs#L134)
- `to_system_config` standalone method introduced in
#135
This was referenced Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(primitives): Remove Payload Module
2 participants