Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): BatchStream Stage Wiring #567

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Sep 24, 2024

Description

Wires up the BatchStream stage into pipeline instantiations.

Makes progress on #559.

Copy link
Collaborator Author

refcell commented Sep 24, 2024

@refcell refcell changed the title feat(derive): wire up the batch span stage feat(derive): BatchSpan Stage Wiring Sep 24, 2024
@refcell refcell requested a review from clabby September 24, 2024 19:02
@refcell refcell added A-derive Area: kona-derive crate H-holocene Hardfork: Holocene related K-feature Kind: feature labels Sep 24, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review September 24, 2024 19:03
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.5%. Comparing base (a610b16) to head (dac37f6).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/pipeline/builder.rs 0.0% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell force-pushed the rf/feat/wire-up-batch-span-stage branch from 3b6b34e to cb71f2d Compare September 24, 2024 19:12
@refcell refcell self-assigned this Sep 24, 2024
@refcell refcell force-pushed the rf/feat/holocene-batch-span-stage branch from 65fbf51 to 5e95560 Compare September 25, 2024 02:44
@refcell refcell force-pushed the rf/feat/wire-up-batch-span-stage branch from cb71f2d to 902435d Compare September 25, 2024 02:44
@refcell refcell changed the title feat(derive): BatchSpan Stage Wiring feat(derive): BatchStream Stage Wiring Sep 25, 2024
@refcell refcell force-pushed the rf/feat/wire-up-batch-span-stage branch from 902435d to 241dd6a Compare September 25, 2024 02:46
@refcell refcell force-pushed the rf/feat/holocene-batch-span-stage branch from 35ee4d2 to 0cec9fe Compare September 25, 2024 22:43
@refcell refcell force-pushed the rf/feat/wire-up-batch-span-stage branch 3 times, most recently from f6d61b0 to 74bb9f2 Compare September 25, 2024 22:56
@refcell refcell changed the base branch from rf/feat/holocene-batch-span-stage to main September 25, 2024 22:56
@refcell refcell added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@refcell refcell added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@refcell refcell enabled auto-merge September 26, 2024 16:40
@refcell refcell force-pushed the rf/feat/wire-up-batch-span-stage branch from 8a94e73 to 6af6cdd Compare September 26, 2024 19:13
@refcell refcell added this pull request to the merge queue Sep 26, 2024
@refcell refcell removed this pull request from the merge queue due to a manual request Sep 26, 2024
@refcell refcell force-pushed the rf/feat/wire-up-batch-span-stage branch from 6af6cdd to dac37f6 Compare September 26, 2024 19:19
@refcell refcell enabled auto-merge September 26, 2024 19:19
@refcell refcell added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit e2a45c5 Sep 26, 2024
16 of 17 checks passed
@github-actions github-actions bot mentioned this pull request Sep 26, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 27, 2024
* feat(derive): wire up the batch span stage (#567)

* fix: missing flush
This was referenced Sep 27, 2024
This was referenced Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate H-holocene Hardfork: Holocene related K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants