Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(derive): Add tracing to ChannelAssembler #701

Merged
merged 2 commits into from
Oct 17, 2024
Merged

chore(derive): Add tracing to ChannelAssembler #701

merged 2 commits into from
Oct 17, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Oct 17, 2024 •
edited
Loading

Overview

Note

Needs #702

Adds tracing to the `ChannelAssembler stage.

@clabby clabby added K-chore Kind: chore A-derive Area: kona-derive crate labels Oct 17, 2024
@clabby clabby self-assigned this Oct 17, 2024
@clabby clabby force-pushed the cl/add-tracing-assembler branch 2 times, most recently from 82bc121 to 0c1fc3c Compare October 17, 2024 04:15
@clabby clabby changed the base branch from main to cl/fix-build October 17, 2024 04:16
@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (2e3c6d5) to head (740ed40).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby force-pushed the cl/add-tracing-assembler branch 2 times, most recently from 0fbd5e5 to 9cd7a8d Compare October 17, 2024 14:56
@clabby clabby marked this pull request as ready for review October 17, 2024 15:43
@clabby clabby requested a review from refcell as a code owner October 17, 2024 15:43
refcell
refcell approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice tests paul allen

@refcell
Copy link
Collaborator

refcell commented Oct 17, 2024

Just needs a restack on main before merge

@refcell
Copy link
Collaborator

refcell commented Oct 17, 2024 •
edited
Loading

Is this st usage I smell?

@clabby clabby force-pushed the cl/add-tracing-assembler branch from 2e1dccb to 740ed40 Compare October 17, 2024 16:16
@clabby clabby changed the base branch from cl/fix-build to main October 17, 2024 16:17
@clabby clabby added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit e884f6e Oct 17, 2024
17 checks passed
This was referenced Oct 17, 2024
Closed
Merged
fakedev9999 pushed a commit to fakedev9999/kona that referenced this pull request Nov 5, 2024
@clabby
chore(derive): Add tracing to ChannelAssembler (op-rs#701)
2a62c7b 
* chore(derive): Add tracing to `ChannelAssembler`

* add log assertions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

Assignees

@clabby clabby

Labels
A-derive Area: kona-derive crate K-chore Kind: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clabby @refcell