This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
chore: Introduce end handle #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
reviewed
Oct 25, 2023
crates/revm/src/evm_impl.rs
Outdated
Comment on lines
172
to
184
| #[inline] | ||
| fn transact_preverified(&mut self) -> EVMResult<DB::Error> { | ||
| let output = self.transact_preverified_inner(); | ||
| self.handler.end(&mut self.data, output) | ||
| } | ||
|
|
||
| #[inline] | ||
| fn transact(&mut self) -> EVMResult<DB::Error> { | ||
| let output = self | ||
| .preverify_transaction() | ||
| .and_then(|()| self.transact_preverified()); | ||
| self.handler.end(&mut self.data, output) | ||
| } |
There was a problem hiding this comment.
This looks safe since OP's end handler will convert the Transaction error over to a Halt variant, making the double-run not happen, but is a bit confusing at first glance. Is there a reason we've split up the end handler calls like this rather than just chaining in transact?
There was a problem hiding this comment.
Yeah, this is not correct, and we should use *_inner() calls. Will make the change.
clabby
approved these changes
Oct 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce end_handle that allows handler to catch all errors.
used inside Optimism to catch deposit transaction error and make into Halt.