feat: Add support for set env vars inside hook runtime #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxymVlasov
commented
Jul 5, 2022
MaxymVlasov
commented
Jul 5, 2022
| @@ -60,6 +64,11 @@ function common::parse_cmdline { | |||
| TF_INIT_ARGS+=("$1") | |||
| shift | |||
| ;; | |||
| -e | --envs) | |||
There was a problem hiding this comment.
@antonbabenko Any ideas on how it can be better named?
Main idea:
You can specify environment variables that will be passed to the hook runtime.
Config example for now
- id: terraform_validate
args:
- --envs=AWS_DEFAULT_REGION="us-west-2"
- --envs=AWS_ACCESS_KEY_ID="anaccesskey"
- --envs=AWS_SECRET_ACCESS_KEY="asecretkey"There was a problem hiding this comment.
@yermulnik proposed --env-vars, but I don't think that much better option, to introduce it and then remove --envs in 2.0.0
There was a problem hiding this comment.
env-vars sounds perfect to me
yermulnik
approved these changes
Jul 5, 2022
Comment on lines
+298
to
+300
| - --envs=AWS_DEFAULT_REGION="us-west-2" | ||
| - --envs=AWS_ACCESS_KEY_ID="anaccesskey" | ||
| - --envs=AWS_SECRET_ACCESS_KEY="asecretkey" |
There was a problem hiding this comment.
As discussed privately we'll get back to reconsidering this option's name later (e.g. to --env-vars or something like that)
Co-authored-by: George L. Yermulnik <yz@yz.kiev.ua>
MaxymVlasov
added this to the Features implementing and cleanup without breaking changes milestone
antonbabenko
pushed a commit
that referenced
this pull request
Jul 12, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Jul 12, 2022
# [1.74.0](v1.73.0...v1.74.0) (2022-07-12) ### Bug Fixes * Add `--env-vars`, deprecate `--envs` ([#410](#410)) ([2b35cad](2b35cad)) * Add `--tf-init-args`, deprecate `--init-args` ([#407](#407)) ([c4f8251](c4f8251)) ### Features * Add support for set env vars inside hook runtime ([#408](#408)) ([d490231](d490231)) * Allow `terraform_providers_lock` specify terraform init args ([#406](#406)) ([32b232f](32b232f)) * Suppress color for all hooks if `PRE_COMMIT_COLOR=never` set ([#409](#409)) ([b12f0c6](b12f0c6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put an
xinto the box if that apply: