Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform_providers_lock): Add --mode option and deprecate previous workflow #528

Merged
merged 15 commits into from
May 30, 2023

Conversation

MaxymVlasov
Copy link
Collaborator

@MaxymVlasov MaxymVlasov commented May 26, 2023

Note: Please review only after merge #527 and rebase master to this branch

Put an x into the box if that apply:

  • This PR introduces breaking change.
  • This PR fixes a bug.
  • This PR adds new functionality.
  • This PR enhances existing functionality.

Description of your changes

Close #526

How can we test changes

repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: 6ac6f293237ac6ad7c259a72c1112e99e7ff57b4
  hooks:
    - id: terraform_providers_lock
      args:
      - --hook-config=--mode=only-check-is-current-lockfile-cross-platform
repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: 6ac6f293237ac6ad7c259a72c1112e99e7ff57b4
  hooks:
    - id: terraform_validate
      args:
        - --hook-config=--retry-once-with-cleanup=true

    - id: terraform_providers_lock
      args:
      - --hook-config=--mode=only-check-is-current-lockfile-cross-platform
repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: 6ac6f293237ac6ad7c259a72c1112e99e7ff57b4
  hooks:
    - id: terraform_validate
      args:
        - --hook-config=--retry-once-with-cleanup=true
        - --tf-init-args=-upgrade

    - id: terraform_providers_lock
      args:
      - --hook-config=--mode=always-regenerate-lockfile

Backward-compatible legacy mode:

repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
  rev: 6ac6f293237ac6ad7c259a72c1112e99e7ff57b4
  hooks:
    - id: terraform_providers_lock

@MaxymVlasov MaxymVlasov requested a review from yermulnik as a code owner May 26, 2023 22:55
@MaxymVlasov MaxymVlasov force-pushed the feat/GH-526 branch 3 times, most recently from deea7bc to fb8f970 Compare May 26, 2023 23:03
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
hooks/terraform_providers_lock.sh Show resolved Hide resolved
hooks/terraform_providers_lock.sh Outdated Show resolved Hide resolved
hooks/terraform_providers_lock.sh Show resolved Hide resolved
hooks/terraform_providers_lock.sh Show resolved Hide resolved
hooks/terraform_providers_lock.sh Show resolved Hide resolved
hooks/terraform_providers_lock.sh Outdated Show resolved Hide resolved
hooks/terraform_providers_lock.sh Show resolved Hide resolved
hooks/terraform_providers_lock.sh Outdated Show resolved Hide resolved
hooks/terraform_providers_lock.sh Outdated Show resolved Hide resolved
@MaxymVlasov MaxymVlasov requested a review from yermulnik May 29, 2023 18:03
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
hooks/terraform_providers_lock.sh Outdated Show resolved Hide resolved
hooks/terraform_providers_lock.sh Outdated Show resolved Hide resolved
hooks/terraform_providers_lock.sh Show resolved Hide resolved
MaxymVlasov and others added 2 commits May 29, 2023 22:28
@MaxymVlasov MaxymVlasov requested a review from yermulnik May 30, 2023 15:21
Copy link
Collaborator

@yermulnik yermulnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Feel free to amend grep-thing later

hooks/terraform_providers_lock.sh Outdated Show resolved Hide resolved
hooks/terraform_providers_lock.sh Outdated Show resolved Hide resolved
hooks/terraform_providers_lock.sh Outdated Show resolved Hide resolved
hooks/terraform_providers_lock.sh Outdated Show resolved Hide resolved
@MaxymVlasov MaxymVlasov merged commit 2426b52 into master May 30, 2023
@MaxymVlasov MaxymVlasov deleted the feat/GH-526 branch May 30, 2023 16:02
antonbabenko pushed a commit that referenced this pull request May 30, 2023
# [1.80.0](v1.79.1...v1.80.0) (2023-05-30)

### Features

* **`terraform_providers_lock`:** Add `--mode` option and deprecate previous workflow ([#528](#528)) ([2426b52](2426b52))
@antonbabenko
Copy link
Owner

This PR is included in version 1.80.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(terraform_providers_lock): Run only when non-cross-platform lockfile found
3 participants