Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for ServiceExternalIP feature #3230

Closed
antoninbas opened this issue Jan 21, 2022 · 5 comments · Fixed by #3524
Closed

Add documentation for ServiceExternalIP feature #3230

antoninbas opened this issue Jan 21, 2022 · 5 comments · Fixed by #3524
Labels
kind/documentation Categorizes issue or PR as related to a documentation.

Comments

@antoninbas
Copy link
Contributor

The ServiceExternalIP feature gate was introduced in Antrea v1.5, but the feature still needs to be documented. We need a doc with examples, just like we have for the egress feature.
@antoninbas antoninbas added the kind/documentation Categorizes issue or PR as related to a documentation. label Jan 21, 2022
@antoninbas antoninbas added this to the Antrea v1.6 release milestone Jan 25, 2022
@tnqn tnqn removed this from the Antrea v1.6 release milestone Mar 25, 2022
@tnqn
Copy link
Member

tnqn commented Mar 25, 2022

No PR is ready for the document, defer it to next release.

@tnqn
Copy link
Member

tnqn commented Mar 25, 2022 •
edited
Loading

@xliuxu could you help document this feature? I don't mean release 1.6.

@xliuxu
Copy link
Contributor

xliuxu commented Mar 25, 2022

@tnqn I think this was already addressed in PR #3322.

@tnqn
Copy link
Member

tnqn commented Mar 25, 2022

@xliuxu thanks for the link. Then we should update https://github.com/antrea-io/antrea/blob/main/docs/feature-gates.md#serviceexternalip with the link and remove "More documentation will be coming in the future."

@xliuxu xliuxu mentioned this issue Mar 25, 2022
Merged
@xliuxu
Copy link
Contributor

xliuxu commented Mar 25, 2022

Thanks for the reminder. Created PR #3524.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to a documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update document for ServiceExternalIP feature xliuxu/antrea
3 participants
@antoninbas @tnqn @xliuxu