Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken install-vm.sh was not detected by any test job #5965

Closed
tnqn opened this issue Feb 6, 2024 · 4 comments
Closed

Broken install-vm.sh was not detected by any test job #5965

tnqn opened this issue Feb 6, 2024 · 4 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@tnqn
Copy link
Member

tnqn commented Feb 6, 2024

"install-vm.sh" was broken since v1.15.0 but never detected. There were several reasons why it was overlooked. See the following thread.


Is there any test that validates hack/externalnode/install-vm.sh?

Yes, I think test-vm-e2e validates it. I think there are two reasons why it was not detected when releasing 1.15:

  1. The trigger comment was not received by jenkin due to transient issue as there was no run since 21th Aug, 2023.
  2. "test-vm-e2e" used the same check name as "test-e2e" to report status, which made it overlooked easily. I will create an issue for it.

Just found the job only validates non-containerized method.

Originally posted by @tnqn in #5957 (comment)

@tnqn
Copy link
Member Author

tnqn commented Feb 6, 2024

cc @XinShuYang @wenyingd

@roopeshsn
Copy link
Contributor

Could you point me to the test-vm-e2e job? @tnqn

@tnqn
Copy link
Member Author

tnqn commented Feb 6, 2024

@roopeshsn thanks for your interest. However this is an issue too specific to the CI and test infra, which is not proper for new contributors.

If you want to take an item, I just filed #5966 and you may feel free to take it.

@tnqn tnqn changed the title test-vm-e2e used the same check name as test-e2e Broken install-vm.sh was not detected by any test job Feb 6, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 7, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants