Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L7 支持百度地图 #1924

Closed
lzxue opened this issue Oct 12, 2023 · 3 comments · Fixed by #1932
Closed

L7 支持百度地图 #1924

lzxue opened this issue Oct 12, 2023 · 3 comments · Fixed by #1932
Assignees

Comments

@lzxue
Copy link
Contributor

lzxue commented Oct 12, 2023

Issue 难度

中等难度

任务介绍

L7 接入百度地图技术方案已经走通,需要进行完善,主要需要完成

1. 初始化方式统一,完善地图初始化化方法:

https://github.com/antvis/L7/blob/master/packages/maps/src/bmap/map.ts#L65

需要实现两种地图初始化方式

方法一: 参数初始化

const scene = new Scene({
  id: 'map',
  map: new BMap({
    pitch: 35.210526315789465,
    style: 'dark',
    center: [ 104.288144, 31.239692 ],
    zoom: 4.4
  })
});

方法二: 支持传入百度地图实例

const scene = new Scene({
   id: 'map',
   map: new GaodeMap({
     mapInstance: map
   })
 });

2. 地图接口统一

不同地图厂商的接口并不完全一致,但是 L7 是对外统一的接口,这样就能实现不同底图之间的切换,要将 L7 的通用接口对应到三方地图的不同接口

https://github.com/antvis/L7/blob/master/packages/core/src/services/map/IMapService.ts#L52

需要实现 IMAPService 里面的接口定义

3. 补充文档

补充如何使用的文档

4. 补充demo.使用教程

增加demo 实例

5. 功能发布

对外宣发,发布稿件

详细介绍

可多人认领,有兴趣可直接回复。

参考说明

No response

@github-actions
Copy link
Contributor

Hello @lzxue. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @lzxue,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到 master 分支,务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@KipSong
Copy link
Contributor

KipSong commented Oct 16, 2023

cc

@lzxue
Copy link
Contributor Author

lzxue commented Oct 16, 2023

cc

感谢参与

@lzxue lzxue added the OSCP 已认领 已认领 label Oct 16, 2023
@lzxue lzxue linked a pull request Oct 16, 2023 that will close this issue
21 tasks
@KipSong KipSong removed their assignment Oct 23, 2023
This was referenced Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants