feat: 补全element props ts 类型 #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 2 alerts when merging ad37de9 into 15e6168 - view on LGTM.com fixed alerts:
|
edokeh
reviewed
Nov 18, 2021
| lineCap?: 'butt' | 'round' | 'square'; | ||
| lineJoin?: 'round' | 'bevel' | 'miter'; | ||
| lineDash?: number[]; | ||
| interface Line extends LineAttrs { | ||
| [key: string]: any; |
| strokeStyle?: string; // 描边文本(strokeText)的颜色 | ||
| lineHeight?: number; | ||
| lineWidth?: number; // 用于描边文本 | ||
| rotate?: number; // 用于旋转文本 | ||
| [key: string]: any; |
edokeh
reviewed
Nov 18, 2021
| @@ -156,3 +169,8 @@ export interface TextAttrs extends ShapeAttrs { | |||
| | 900; | |||
| fontVariant?: 'normal' | 'small-caps'; | |||
| } | |||
|
|
|||
| export interface CustomAttrs extends ShapeAttrs { | |||
There was a problem hiding this comment.
这个我记得有定义一个 CustomProp 的，是对 this._attr 的定义
怎么又搞了个 CustomAttr？而且这里也没用到呀
There was a problem hiding this comment.
没有吧，this._attr 是 graphic 里的 ElementProps， 这里是把所有的 shape 类型都 export 出来了
zengyue
force-pushed
the
feat-improve-ts
branch
from
ad37de9
to
679a55c
Compare
|
This pull request fixes 2 alerts when merging 679a55c into 593b323 - view on LGTM.com fixed alerts:
|
zengyue
force-pushed
the
feat-improve-ts
branch
from
679a55c
to
7af348f
Compare
|
This pull request fixes 2 alerts when merging 7af348f into 593b323 - view on LGTM.com fixed alerts:
|
zengyue
force-pushed
the
feat-improve-ts
branch
from
7af348f
to
fe8f65f
Compare
|
This pull request fixes 2 alerts when merging fe8f65f into 593b323 - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change