Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(padding): add a test case #2803

Merged
merged 1 commit into from
Sep 7, 2020
Merged

test(padding): add a test case #2803

merged 1 commit into from
Sep 7, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Sep 7, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@auto-add-label auto-add-label bot added the test label Sep 7, 2020
@hustcc hustcc requested a review from simaQ September 7, 2020 03:17
@lgtm-com
Copy link

lgtm-com bot commented Sep 7, 2020

This pull request fixes 1 alert when merging c474d28 into 4432e0e - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

visiky
visiky approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@visiky visiky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不使用 autoPadding 了，顺便好奇 padding 和 appendPadding 的区别

@hustcc
Copy link
Member Author

hustcc commented Sep 7, 2020

autoPadding

autoPadding 这个变量在这个文件没有用到，所以删除了。

padding：可以是 auto 和确定的值，appendPadding 是在 padding 的基础上再加一个确定的 padding。

可以组合出 'auto' + [8, 8, 8, 8] 这种效果

@hustcc hustcc merged commit 87e8344 into master Sep 7, 2020
@hustcc hustcc deleted the chore-add-testcase branch September 7, 2020 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky approved these changes

@simaQ simaQ Awaiting requested review from simaQ

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hustcc @visiky