Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(view): add syncViewPadding support callback #2995

Merged
merged 2 commits into from
Nov 10, 2020
Merged

feat(view): add syncViewPadding support callback #2995

merged 2 commits into from
Nov 10, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Nov 10, 2020

  • syncViewPadding function
  • padding cal
  • test

@github-actions
Copy link

github-actions bot commented Nov 10, 2020 •
edited
Loading

😭 Deploy PR Preview c8355f2 failed. Build logs

🤖 By surge-preview

@hustcc hustcc requested review from lessmost and visiky November 10, 2020 09:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 355583496

  • 19 of 19 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 93.435%
Totals Coverage Status
Change from base Build 355138244: 0.01%
Covered Lines: 10468
Relevant Lines: 10869
💛 - Coveralls

@hustcc hustcc requested a review from lessmost November 10, 2020 09:56
@lessmost lessmost merged commit c8355f2 into master Nov 10, 2020
@lessmost lessmost deleted the feat-sync-view-padding-func branch November 10, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lessmost lessmost lessmost approved these changes

@visiky visiky Awaiting requested review from visiky

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hustcc @coveralls @lessmost