Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interval support cornerRadius(方案梳理中) #3170

Merged
merged 4 commits into from
Jan 13, 2021
Merged

Conversation

visiky
Copy link
Member

@visiky visiky commented Jan 4, 2021

PR details

interval 支持配置 style.radius: 柱状图支持圆角

  • 目前支持笛卡尔坐标系下的 interval geometry 且 shape 为 rect 的几何图形进行设置 radius
  • radius 配置说明
非转置坐标系 image
转置坐标系 image
Config After
interval().position('x*y').style({ radius: [20,20,0,0] })

checklist

  • 异常分支
  • test cases
  • docs(后续再补充)
正常场景 image
堆叠场景 image
存在负值场景

@github-actions
Copy link

github-actions bot commented Jan 4, 2021

😭 Deploy PR Preview b09b54c failed. Build logs

🤖 By surge-preview

@visiky visiky changed the title wip: feat: interval support cornerRadius(方案梳理中) feat: interval support cornerRadius(方案梳理中) Jan 13, 2021
@visiky visiky changed the title feat: interval support cornerRadius(方案梳理中) wip:feat: interval support cornerRadius(方案梳理中) Jan 13, 2021
@visiky visiky changed the title wip:feat: interval support cornerRadius(方案梳理中) feat: interval support cornerRadius(方案梳理中) Jan 13, 2021
@visiky
Copy link
Member Author

visiky commented Jan 13, 2021

related: antvis/G2Plot#2157

@lgtm-com
Copy link

lgtm-com bot commented Jan 13, 2021

This pull request introduces 1 alert when merging 1d108e0 into ae651fe - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Jan 13, 2021

This pull request introduces 1 alert when merging b09b54c into ae651fe - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 482174623

  • 24 of 26 (92.31%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 93.493%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/geometry/shape/interval/util.ts 21 23 91.3%
Totals Coverage Status
Change from base Build 482007291: 0.01%
Covered Lines: 10820
Relevant Lines: 11226

💛 - Coveralls

@hustcc hustcc merged commit 31f41bf into master Jan 13, 2021
@hustcc hustcc deleted the feat-corner-radius branch January 13, 2021 08:02
@donglegend
Copy link

PR details

interval 支持配置 style.radius: 柱状图支持圆角

  • 目前支持笛卡尔坐标系下的 interval geometry 且 shape 为 rect 的几何图形进行设置 radius
  • radius 配置说明

非转置坐标系 image
转置坐标系 image
Config After
interval().position('x*y').style({ radius: [20,20,0,0] })

checklist

  • 异常分支
  • test cases
  • docs(后续再补充)

正常场景 image
堆叠场景 image
存在负值场景

堆叠场景下有点奇怪啊,想要下面这种,希望提供一些 配置项接口可供开发者配置,🤝
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants