Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(event): 修复相同 type 事件触发两次 #3282

Merged
merged 2 commits into from
Feb 8, 2021
Merged

fix(event): 修复相同 type 事件触发两次 #3282

merged 2 commits into from
Feb 8, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Feb 8, 2021

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

触发 plot 事件的时候，不应该修改事件 type。应该保持 emit 类型 和 event 的 type 类型一致

@visiky visiky requested a review from hustcc February 8, 2021 07:56
@visiky visiky mentioned this pull request Feb 8, 2021
Closed
@github-actions
Copy link

github-actions bot commented Feb 8, 2021 •
edited
Loading

😭 Deploy PR Preview dbe0cbc failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 547283409

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 93.593%
Totals Coverage Status
Change from base Build 546828157: 0.08%
Covered Lines: 10851
Relevant Lines: 11249
💛 - Coveralls

@lxfu1 lxfu1 mentioned this pull request Feb 8, 2021
Closed
@visiky visiky merged commit 9d61410 into master Feb 8, 2021
@visiky visiky deleted the same-event-trigger-twice branch February 8, 2021 08:53
@visiky visiky changed the title fix(event): 修复相同 type 时间触发两次 fix(event): 修复相同 type 事件触发两次 Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @hustcc