Skip to content

Commit ac8a890

Browse files
committed
HADOOP-18679. Followup: change method name case (apache#6854)
WrappedIO.bulkDelete_PageSize() => bulkDelete_pageSize() Makes it consistent with the HADOOP-19131 naming scheme. The name needs to be fixed before invoking it through reflection, as once that is attempted the binding won't work at run time, though compilation will be happy. Contributed by Steve Loughran
1 parent f0a2484 commit ac8a890

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/wrappedio/WrappedIO.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ private WrappedIO() {
5454
* @throws IllegalArgumentException path not valid.
5555
* @throws IOException problems resolving paths
5656
*/
57-
public static int bulkDelete_PageSize(FileSystem fs, Path path) throws IOException {
57+
public static int bulkDelete_pageSize(FileSystem fs, Path path) throws IOException {
5858
try (BulkDelete bulk = fs.createBulkDelete(path)) {
5959
return bulk.pageSize();
6060
}

hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractBulkDeleteTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public abstract class AbstractContractBulkDeleteTest extends AbstractFSContractT
6969
public void setUp() throws Exception {
7070
fs = getFileSystem();
7171
basePath = path(getClass().getName());
72-
pageSize = WrappedIO.bulkDelete_PageSize(getFileSystem(), basePath);
72+
pageSize = WrappedIO.bulkDelete_pageSize(getFileSystem(), basePath);
7373
fs.mkdirs(basePath);
7474
}
7575

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestAssumeRole.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -735,7 +735,7 @@ private void executeBulkDeleteOnReadOnlyFiles(Configuration assumedRoleConfig) t
735735

736736
bindReadOnlyRolePolicy(assumedRoleConfig, readOnlyDir);
737737
roleFS = (S3AFileSystem) destDir.getFileSystem(assumedRoleConfig);
738-
int bulkDeletePageSize = WrappedIO.bulkDelete_PageSize(roleFS, destDir);
738+
int bulkDeletePageSize = WrappedIO.bulkDelete_pageSize(roleFS, destDir);
739739
int range = bulkDeletePageSize == 1 ? bulkDeletePageSize : 10;
740740
touchFiles(fs, readOnlyDir, range);
741741
touchFiles(roleFS, destDir, range);
@@ -769,7 +769,7 @@ private void executeBulkDeleteOnSomeReadOnlyFiles(Configuration assumedRoleConfi
769769
bindReadOnlyRolePolicy(assumedRoleConfig, readOnlyDir);
770770
roleFS = (S3AFileSystem) destDir.getFileSystem(assumedRoleConfig);
771771
S3AFileSystem fs = getFileSystem();
772-
if (WrappedIO.bulkDelete_PageSize(fs, destDir) == 1) {
772+
if (WrappedIO.bulkDelete_pageSize(fs, destDir) == 1) {
773773
String msg = "Skipping as this test requires more than one path to be deleted in bulk";
774774
LOG.debug(msg);
775775
skip(msg);

0 commit comments

Comments
 (0)