Skip to content
This repository has been archived by the owner on Feb 25, 2019. It is now read-only.

RSA parameter selection #67

Closed
EternalDeiwos opened this issue Feb 9, 2018 · 3 comments
Closed

RSA parameter selection #67

EternalDeiwos opened this issue Feb 9, 2018 · 3 comments
Labels
bug low priority

Comments

@EternalDeiwos
Copy link
Member

The following code (and the same for .verify) should be using this.hash.name as the keys themselves aren't bound to a specific hash.

https://github.com/anvilresearch/webcrypto/blob/master/src/algorithms/RSASSA-PKCS1-v1_5.js#L81-L91

I tried doing a quick fix for this but it breaks all the tests.
@thelunararmy
Copy link
Contributor

Woops, this should be class. Will fix.

@thelunararmy
Copy link
Contributor

Fixed in 97cfbe3 , just waiting for latest merge then I'll PR it.

@EternalDeiwos EternalDeiwos mentioned this issue Apr 3, 2018
Merged
@EternalDeiwos
Copy link
Member Author

Fixed in #69. Closing.

@thelunararmy thelunararmy mentioned this issue Jul 19, 2018
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EternalDeiwos @thelunararmy