Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgraded msw to 2.0 #1007

Merged
merged 3 commits into from
Nov 2, 2023
Merged

feat: upgraded msw to 2.0 #1007

merged 3 commits into from
Nov 2, 2023

Conversation

Will-Mann-16
Copy link
Contributor

@Will-Mann-16 Will-Mann-16 commented Nov 2, 2023 •
edited by melloware
Loading

Status

READY

Description

Upgraded MSW to version 2.0, and moved the response to the appropriate type here.

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Fix #1005
Fix #855

@melloware melloware added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 2, 2023
melloware
melloware requested changes Nov 2, 2023
View reviewed changes
packages/msw/src/index.ts Show resolved Hide resolved
melloware
melloware approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic thanks!

@melloware melloware merged commit cc3e72a into orval-labs:master Nov 2, 2023
2 of 3 checks passed
@ppalmeida
Copy link

This is wonderful! Is there a scheduled date for this to be published?

@melloware
Copy link
Collaborator

Not yet i pinged Victor to do a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade MSW to 2.0 @orval/msw has deprecated and insecure dependency
3 participants
@Will-Mann-16 @ppalmeida @melloware