feat: generate literal types for booleans and numbers #1512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Allows for the generation of literal types for booleans and numbers. Fixes #1509.
Todos
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
> git clone https://github.com/RinseV/orval.git
tests
folder:yarn generate:default
Notes
I didn't want to break the current functionality from #1326 where not specifying a
type
will generate it as a string literal. So, having onlyconst
without atype
will still generate as a string. The same is true for atype
ofstring
. But if thetype
is eithernumber
,integer
orboolean
, the type will be generated as the literal value ofconst
. This can result in invalid code (like specifying a property withtype: number
andconst: value
which will generate asproperty: value
).Comparison
Schema:
Before
Now