feat: sort schema barrel file #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix anymaniax#483 sort schema barrel file
|
Someone is attempting to deploy a commit to a Personal Account owned by @anymaniax on Vercel. @anymaniax first needs to authorize it. |
anymaniax
reviewed
Aug 15, 2022
adding promise.all
|
Changes made, requesting re-review |
anymaniax
approved these changes
Aug 23, 2022
|
@SamKirkland Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #483 sort schema barrel file
Note
When testing this change I found the output of many example folders to be out of date. I didn't want to pollute this PR so I left those files out of this PR. I did leave the
samples/react-query/basic/src/api/model/index.tsfile in this PR as an example of what this change accomplishes.Status
READY
Description
The contents of the schema barrel files (model/index.ts) should be stable between builds - the output between re-runs should be identical. This has several benefits, including less noisy git diffs.
This change also reduces IO trashing because it removes 2 IO operations that were previously within a loop (read file, append file)
Related PRs
Non
Todos
Steps to Test or Reproduce
samples/react-query/basicnpm installorval --config ./orval.config.tssamples/react-query/basic/src/api/model/index.tsorval --config ./orval.config.ts