-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation under Windows #14
Comments
Hi, Andrzej! Any news on this issue? Or pointers of what I could try to help troubleshooting? -Geo |
I also face the same problem in windows 10 on my own computer and work place. |
I think the problem is due to java class path isn't set properly when .jfield("loci/formats/FormatTools", "S", "VERSION") is called. I downloaded "bioformats_package.jar" first and put it in one folder, then entered the utils.R file and change some code from: |
Doesn't seem to work in my installation - it still downloads the file and fails with call: .jfield. |
Same issue here (R 3.5.3, Windows10). I don't understand where do I find the "utils.R" file so to try @Wang-Hsiang-Sheng suggestion. |
What worked for me. |
The @manerotoni method worked for me, but I would like to add that you ofcause have to install the library afterwards from the filepath that was created with devtools::build().
git clone https://github.com/aoles/RBioFormats.git
BioFormats.version = function() .jfield("loci/formats/FormatTools", "S", "VERSION")"
to:
"BioFormats.version = function() {
library(rJava)
.jinit()
.jaddClassPath(location of "bioformats_package.jar" just downloaded) ## in my case ".jaddClassPath("C:/R/Library/bioformats/bioformats_package.jar")"
.jfield("loci/formats/FormatTools", "S", "VERSION")
}
run devtools::build() # you may need to install additional packages
# [1] "C:/R/RBioFormats_0.0.54.tar.gz"
install.packages("C:/R/RBioFormats_0.0.54.tar.gz", repos = NULL, type = "source") |
This works perfect. Those last steps were not clear to me (location of library/bioformats vs. repo clone) before. |
I just noticed that now it downloads the bioformats package everytime the library is loaded. Do you see this as well? |
Hi guys, joining the party late - let me apologize for this! First off all, many thanks to all of you involved in debugging this, I really appreciate your commitment. Normally JVM initialization should be performed through For now could you maybe verify whether disabling the package startup message resolves the issue? Please try running the modified version through devtools::install_github("aoles/RBioFormats@debug"). Looking forward to your feedback! Cheers, |
Nice - this installed like a charm on a vanilla Windows 7, RStudio, R3.5.3 64bit. However, it still downloads the bioformats package from openmicroscopy.org whenever the RBioFormats library is loaded. |
Thanks @GrauKatze for getting back to me so quickly! I've just modified the test branch to print some debug messages, would you mind reinstalling the package once again and paste here the output you get when you load the package? Cheers, |
|
Awesome, thanks! So the problem comes from the fact that the checksum of your local library copy does not match the remote one, weird. Do you consistently get the same value |
Yes, it is the identical message each time. |
Thanks for verifying! Might be related to the following comment in
Could you maybe check what value you get when you manually download the file https://downloads.openmicroscopy.org/bio-formats/6.0.0/artifacts/bioformats_package.jar and run |
|
Great, thanks a lot! So I guess we can rule out Cheers, url <- "https://downloads.openmicroscopy.org/bio-formats/6.0.0/artifacts/bioformats_package.jar"
for (m in c("w", "wb")) {
f <- tempfile("", , ".jar")
utils::download.file(url, f, mode = m, quiet = TRUE)
message(tools::md5sum(f))
} |
I ran this 2x, with different results:
|
Great, thanks a lot! So the problem with reoccurring downloads was caused by the default Additionally, I've updated the way how the library version is being resolved during startup. Looking forward to your feedback! Cheers, |
This looks good (on Windows 10 and macOS)!
|
Awesome, glad to hear that! |
Hi, Andrzej!
I am stuck while trying to install Rbioformats in Windows 10. Rtools and devtools are installed, packages can be compile from source. rJava compiled fine and loads properly. However, when running I get
I get the following output:
BioC_mirror: https://bioconductor.org
Using Bioconductor 3.7 (BiocInstaller 1.30.0), R 3.5.1 (2018-07-02).
Installing github package(s) ‘aoles/RBioFormats’
Downloading GitHub repo aoles/RBioFormats@master
Installing package into ‘C:/Users/Geo/Documents/R/win-library/3.5’
(as ‘lib’ is unspecified)
installing source package 'RBioFormats' ...
** R
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
converting help for package 'RBioFormats'
finding HTML links ... done
AnnotatedImage-class html
finding level-2 HTML links ... done
AnnotatedImageList-class html
BioFormats.version html
FormatTools html
ImageMetadata-class html
RBioFormats html
checkJavaMemory html
dimorder html
metadata html
metadataAccessors html
mockFile html
read.image html
read.metadata html
read.omexml html
seriesCount html
write.image html
** building package indices
** installing vignettes
** testing if installed package can be loaded
trying URL 'https://downloads.openmicroscopy.org/bio-formats/5.9.1/artifacts/bioformats_package.jar'
Content type 'application/x-java-archive' length 31779356 bytes (30.3 MB)
==================================================
downloaded 30.3 MB
Error: package or namespace load failed for 'RBioFormats':
.onLoad failed in loadNamespace() for 'RBioFormats', details:
call: .jfield("loci/formats/FormatTools", "S", "VERSION")
error: cannot find class loci/formats/FormatTools
Error: loading failed
Execution halted
ERROR: loading failed
In R CMD INSTALL
Warning message:
In i.p(...) :
installation of package ‘C:/Users/Geo/AppData/Local/Temp/RtmpU7bsbM/remotes13fc5a4431eb/aoles-RBioFormats-9d104f6’ had non-zero exit status
Do you have an idea what might go wrong?
Many thanks in advance,
Geo
From: "Andrzej K. Oleś" notifications@github.com
Reply-To: aoles/RBioFormats reply@reply.github.com
Date: Sunday, May 13, 2018 at 1:03 PM
To: aoles/RBioFormats RBioFormats@noreply.github.com
Cc: Geo Vogler GEO.VOGLER@GMAIL.COM, State change state_change@noreply.github.com
Subject: Re: [aoles/RBioFormats] meta data is different between ImageJ and RBioformats (#11)
Hi Geo,
thank you for reaching out and for reporting the disappointing performance of read.metadata. I will look int this, I've opened a dedicated issue#12 in order to better keep track of it.
Best,
Andrzej
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub#11 (comment), or mute the threadhttps://github.com/notifications/unsubscribe-auth/AaGUenMsW-xwAM96YwOFxAUFg_aRCrKjks5tyJF3gaJpZM4Sppuu.
Originally posted by @GrauKatze in #11 (comment)
The text was updated successfully, but these errors were encountered: