Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(legacy-preset-chart-big-number): example images got mixed up #1196

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

suddjian
Copy link
Member

@suddjian suddjian commented Jul 1, 2021

💔 Breaking Changes

🏆 Enhancements

📜 Documentation

🐛 Bug Fix

This puts the trendline image on the big number with trendline, and the regular image on the regular big number

🏠 Internal

@suddjian suddjian requested a review from a team as a code owner July 1, 2021 07:35
@vercel
Copy link

vercel bot commented Jul 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/3Laf1JX2aDpmcWNMvizFc8Vn9qaH
✅ Preview: https://superset-ui-git-fix-big-number-examples-superset.vercel.app

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #1196 (1728578) into master (19b27f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1196   +/-   ##
=======================================
  Coverage   29.09%   29.09%           
=======================================
  Files         463      463           
  Lines        9358     9358           
  Branches     1496     1496           
=======================================
  Hits         2723     2723           
  Misses       6424     6424           
  Partials      211      211           
Impacted Files Coverage Δ
...acy-preset-chart-big-number/src/BigNumber/index.ts 0.00% <ø> (ø)
...reset-chart-big-number/src/BigNumberTotal/index.ts 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b27f0...1728578. Read the comment docs.

@junlincc
Copy link
Contributor

junlincc commented Jul 1, 2021

thanks @suddjian 🙏! mind adding corresponding/before-after screenshots to the PR?

@suddjian
Copy link
Member Author

suddjian commented Jul 1, 2021

There aren't really screenshots to give you, this doesn't change UI or anything about the plugin. These are just the images used in the examples list in the new modal. The Big Number with Trendline ended up getting the non-trendline images and the non-trendline Big Number got the example image with trendline, so I switched them to be correct.

@rusackas rusackas merged commit 60215b5 into master Jul 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-big-number-examples branch July 1, 2021 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants