Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: wrong type for filters field #183

Merged
merged 1 commit into from
Jun 19, 2019
Merged

fix: wrong type for filters field #183

merged 1 commit into from
Jun 19, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Jun 19, 2019

  • type of filters field is an object, not array. The name filters is misleading because it is actually the initial values of filter_box and table

@kristw kristw requested a review from a team as a code owner June 19, 2019 19:18
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #183 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #183   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          94     94           
  Lines        1159   1159           
  Branches      276    276           
=====================================
  Hits         1159   1159
Impacted Files Coverage Δ
...ackages/superset-ui-chart/src/models/ChartProps.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d363baa...12f7684. Read the comment docs.

@netlify
Copy link

netlify bot commented Jun 19, 2019

Deploy preview for superset-ui ready!

Built with commit 12f7684

https://deploy-preview-183--superset-ui.netlify.com

@kristw kristw merged commit 18ef7d9 into master Jun 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--fix-type branch June 19, 2019 19:48
kristw added a commit that referenced this pull request Apr 17, 2020
* build: update dependencies

* feat: replace payload with queryData

* feat: replace payload with queryData

* fix: rename hooks

* fix: types from query package

* fix: more typings

* docs: update readme

* fix: import query

* fix: change NOOP to const

* fix: update dependency versions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants