This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat: add functions for parsing formatters from encoding #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for superset-ui ready! Built with commit 24e5a14 |
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 99.91% 99.91% +<.01%
==========================================
Files 107 111 +4
Lines 1222 1239 +17
Branches 297 303 +6
==========================================
+ Hits 1221 1238 +17
Partials 1 1
Continue to review full report at Codecov.
|
kristw
force-pushed
the
kristw--encodeable2
branch
from
694f02f to
666bd61
Compare
isaacpz
reviewed
Aug 16, 2019
| import { ChannelDef } from '../types/ChannelDef'; | ||
| import { isValueDef } from '../typeGuards/ChannelDef'; | ||
|
|
||
| export default function createGetterFromChannelDef(definition: ChannelDef): (x?: any) => any { |
There was a problem hiding this comment.
Could this function have more explicit typing? If not, would be good to leave a comment documenting expected input/output
|
LGTM as well |
kristw
pushed a commit
that referenced
this pull request
Apr 17, 2020
Updates the requirements on [@types/storybook__react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/storybook__react) to permit the latest version. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/storybook__react) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements