Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Use simple js code to create range #24

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Use simple js code to create range #24

merged 1 commit into from
Nov 6, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Nov 6, 2018

🐛 Bug Fix

The current code is using Array(n).keys() which requires iterator polyfill. Switch to plain old js for simplicity.

@kristw kristw self-assigned this Nov 6, 2018
@kristw kristw added the reviewable Ready for review label Nov 6, 2018
Copy link
Contributor

@xtinec xtinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #24   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          30     37    +7     
  Lines         260    325   +65     
=====================================
+ Hits          260    325   +65
Impacted Files Coverage Δ
packages/superset-ui-color/src/SequentialScheme.js 100% <100%> (ø) ⬆️
.../src/registries/ChartComponentRegistrySingleton.js 100% <0%> (ø)
...t/src/registries/ChartMetadataRegistrySingleton.js 100% <0%> (ø)
...src/registries/ChartBuildQueryRegistrySingleton.js 100% <0%> (ø)
...registries/ChartTransformPropsRegistrySingleton.js 100% <0%> (ø)
...ages/superset-ui-chart/src/models/ChartMetadata.js 100% <0%> (ø)
...ackages/superset-ui-chart/src/models/ChartProps.js 100% <0%> (ø)
...ckages/superset-ui-chart/src/models/ChartPlugin.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b191e7a...b9bd8f6. Read the comment docs.

@kristw kristw merged commit 72c8e09 into master Nov 6, 2018
@kristw kristw deleted the kristw--range branch November 6, 2018 22:50
@kristw kristw added this to the v0.5.0 milestone Nov 13, 2018
@kristw kristw added reviewable Ready for review and removed reviewable Ready for review labels Nov 13, 2018
@kristw kristw added #bug Something isn't working and removed reviewable Ready for review labels Dec 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
#bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants