This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat: add more support for undefined format to number and time formatters #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 103 103
Lines 1223 1225 +2
Branches 300 300
=====================================
+ Hits 1223 1225 +2
Continue to review full report at Codecov.
|
|
Deploy preview for superset-ui ready! Built with commit 4f9db76 |
ktmud
reviewed
Mar 4, 2020
| formatterId === null || typeof formatterId === 'undefined' || formatterId === '' | ||
| ? this.defaultKey | ||
| : formatterId | ||
| }`.trim(); |
There was a problem hiding this comment.
I appreciate the explicitness, but could this be simplified as formatterId ?? (formatterId || this.defaultKey).
There was a problem hiding this comment.
eslint will try to change || to ??
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Follow up from feat: make formatTime and formatNumber accept undefined type #307 , make
formatTime,getTimeFormatter,formatNumber,getNumberFormatterhandleundefinedformat.Bring back support for empty string as format. This was due to the recent change from
||to??.The code used to be
format || defaultFormat, and it was changed byeslintauto-fix toformat ?? defaultFormat.