Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: add calendar package and storybook #356

Merged
merged 4 commits into from
Apr 11, 2020
Merged

feat: add calendar package and storybook #356

merged 4 commits into from
Apr 11, 2020

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Apr 10, 2020

🏆 Enhancements

Migrate legacy-plugin-chart-calendar from @superset-ui-plugins

@kristw kristw requested a review from a team as a code owner April 10, 2020 23:13
@vercel
Copy link

vercel bot commented Apr 10, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/superset/superset-ui/29li6erpq
✅ Preview: https://superset-ui-git-kristw-migrate2.superset.now.sh

@kristw kristw requested a review from ktmud April 10, 2020 23:13
@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #356 into master will decrease coverage by 39.88%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #356       +/-   ##
===========================================
- Coverage   91.67%   51.78%   -39.89%     
===========================================
  Files         118      122        +4     
  Lines        1489     2636     +1147     
  Branches      388      388               
===========================================
  Hits         1365     1365               
- Misses         95     1242     +1147     
  Partials       29       29               
Impacted Files Coverage Δ
...ugins/legacy-plugin-chart-calendar/src/Calendar.js 0.00% <0.00%> (ø)
plugins/legacy-plugin-chart-calendar/src/index.js 0.00% <0.00%> (ø)
...legacy-plugin-chart-calendar/src/transformProps.js 0.00% <0.00%> (ø)
...cy-plugin-chart-calendar/src/vendor/cal-heatmap.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308f2ab...8276373. Read the comment docs.

Copy link
Contributor

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Might have to adjust codecov targets later. Probably have a separate target for core packages and ignore project level and plugin level coverages.

@kristw kristw merged commit daf47bd into master Apr 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the kristw--migrate2 branch April 11, 2020 05:29
kristw pushed a commit that referenced this pull request Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants