This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat: make time formatter handle number and fix formatters type warnings #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/superset/superset-ui/la9j0u5gi |
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
+ Coverage 51.78% 52.69% +0.90%
==========================================
Files 122 122
Lines 2636 2693 +57
Branches 388 417 +29
==========================================
+ Hits 1365 1419 +54
+ Misses 1242 1241 -1
- Partials 29 33 +4
Continue to review full report at Codecov.
|
kristw
changed the title
ktmud
approved these changes
Apr 13, 2020
kristw
pushed a commit
that referenced
this pull request
Apr 17, 2020
Bumps [@vx/scale](https://github.com/hshoff/vx) from 0.0.192 to 0.0.194. - [Release notes](https://github.com/hshoff/vx/releases) - [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md) - [Commits](airbnb/visx@v0.0.192...v0.0.194) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Enhancement
Add support for time formatter to handle
number, it will treat the number as timestamp and convert toDate. This is consistent with howd3-time-formatusually works.🐛 Bug Fix
Fix this warning for
NumberFormatterandTimeFormattervia type augmentation.