Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Add overwritePolicy for Registry #37

Merged
merged 3 commits into from
Nov 19, 2018
Merged

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Nov 18, 2018

💔 Breaking Changes

BREAKING CHANGE: Change Registry constructor API to take object instead of single string name.

This constructor has not been called anywhere in incubator-superset. It is only used in other packages in @superset-ui, which are also updated in this PR.

🏆 Enhancements

feat: Add overwritePolicy for Registry so developer can customize whether overwriting is ALLOW, WARN or PROHIBIT.

🏠 Internal

fix: Change variable name options to config for consistency.

@kristw kristw requested a review from a team as a code owner November 18, 2018 08:31
@codecov
Copy link

codecov bot commented Nov 18, 2018

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #37   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          48     48           
  Lines         407    420   +13     
=====================================
+ Hits          407    420   +13
Impacted Files Coverage Δ
...src/registries/ChartBuildQueryRegistrySingleton.js 100% <100%> (ø) ⬆️
.../src/registries/ChartComponentRegistrySingleton.js 100% <100%> (ø) ⬆️
...t/src/registries/ChartMetadataRegistrySingleton.js 100% <100%> (ø) ⬆️
packages/superset-ui-core/src/models/Registry.js 100% <100%> (ø) ⬆️
...registries/ChartTransformPropsRegistrySingleton.js 100% <100%> (ø) ⬆️
...erset-ui-core/src/models/RegistryWithDefaultKey.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf4f821...decb9e8. Read the comment docs.

@kristw kristw added the reviewable Ready for review label Nov 18, 2018
@kristw kristw added this to the v0.7.0 milestone Nov 18, 2018
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add! 🤩

@kristw kristw merged commit d4bdc78 into master Nov 19, 2018
@delete-merged-branch delete-merged-branch bot deleted the kristw--registry-overwrite branch November 19, 2018 20:53
@kristw kristw removed reviewable Ready for review labels Nov 19, 2018
@kristw kristw added risk:breaking-change #enhancement New feature or request and removed reviewable Ready for review risk:breaking-change labels Dec 6, 2018
kristw added a commit that referenced this pull request Apr 17, 2020
* fix: change references to vega-lite that broke build

* refactor: rename fielddef to channeldef
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
#enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants