This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat: migrate chart plugins #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/superset/superset-ui/9232jhg77 |
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 32.03% 26.83% -5.20%
==========================================
Files 155 188 +33
Lines 4308 5161 +853
Branches 422 459 +37
==========================================
+ Hits 1380 1385 +5
- Misses 2899 3747 +848
Partials 29 29
Continue to review full report at Codecov.
|
kristw
commented
Apr 17, 2020
| @@ -58,6 +58,75 @@ function getAncestors(node) { | |||
| return path; | |||
| } | |||
|
|
|||
| function buildHierarchy(rows) { | |||
There was a problem hiding this comment.
Just move function outside to please eslint
kristw
force-pushed
the
kristw--migrate-more
branch
from
1709cd4 to
761d3d0
Compare
villebro
approved these changes
Apr 17, 2020
|
Removal PR: apache-superset/superset-ui-plugins#440 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Migrate
Most of the changes are
eslintauto fix viayarn lint:fix.And update storybook structure to match the new way.