Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

plugin-chart-table not using new API? #859

Closed
AydinChavez opened this issue Dec 10, 2020 · 7 comments
Closed

plugin-chart-table not using new API? #859

AydinChavez opened this issue Dec 10, 2020 · 7 comments

Comments

@AydinChavez
Copy link

The README.MD states:

@superset-ui/plugin-* packages are newer and higher quality in general. A key difference that they do not depend on viz.py (which contain visualization-specific python code) and interface with /api/v1/query/, a new generic endpoint instead meant to serve all visualizations, instead.

But according to
https://github.com/apache-superset/superset-ui/blob/master/plugins/plugin-chart-table/src/index.ts#L31
it's still using the legacy api (viz.py) ?

I would expect that it uses the new api as stated in the doc.

@ktmud
Copy link
Contributor

ktmud commented Dec 10, 2020

We are in the process of migrating it to the new API. The table chart was completely rewritten recently but the API was kept the same as the first iteration.

@AydinChavez
Copy link
Author

AydinChavez commented Dec 10, 2020

Do you know when the migration towards the new API for this particular table chart plugin will be finished?

When switching to the new API, I always get "No records found" (although there is a response containing result data according to dev console). Also switching from agg to raw queryMode seems not to be recognized..

@ktmud
Copy link
Contributor

ktmud commented Dec 10, 2020

Before EOY.

@AydinChavez
Copy link
Author

Okay, great.

@AydinChavez
Copy link
Author

Any update on this one?

@maxenz
Copy link

maxenz commented Feb 18, 2021

I'm having the same problem, any news? I always get no records found...

@ktmud
Copy link
Contributor

ktmud commented Feb 18, 2021

Hi, the table chart has been migrated to the new API: #889

We are still actively working on this chart, so feel free to report any bugs you saw or other feature requests for the table chart in the main Superset repo: https://github.com/apache/superset/issues

@ktmud ktmud closed this as completed Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants