Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate connections UI #12401

Closed
JavierLopezT opened this issue Nov 17, 2020 · 6 comments · Fixed by #15574
Closed

Duplicate connections UI #12401

JavierLopezT opened this issue Nov 17, 2020 · 6 comments · Fixed by #15574
Assignees
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues good first issue kind:feature Feature Requests
Milestone

Comments

@JavierLopezT
Copy link
Contributor

JavierLopezT commented Nov 17, 2020

In the UI it would be nice to duplicate the selected connection, in the menu "With Selected".

The copy would be set with the same name plus some suffix (_copy, _1, whatever) and it is useful for when you have a connection with all equal fields except something in a particular one.

@JavierLopezT JavierLopezT added the kind:feature Feature Requests label Nov 17, 2020
@mik-laj mik-laj added area:webserver Webserver related Issues good first issue labels Nov 17, 2020
@mik-laj
Copy link
Member

mik-laj commented Nov 17, 2020

Sound good to me. Can I assign you to this ticket?

@JavierLopezT
Copy link
Contributor Author

Sound good to me. Can I assign you to this ticket?

I have no clue how to approach this and right now I don't have time to investigate, sorry

@honarkhah
Copy link
Contributor

honarkhah commented Nov 23, 2020

I would like to work on this task, Should I add a new permission or use the can_create permission?
airflow/www/templates/airflow/model_list.html:L71

      {% if can_show or can_edit or can_delete %}
        <td><center>
        {{ lib.btn_crud(can_show, can_edit, can_delete, pk, modelview_name, filters) }}
        </center></td>
      {% endif %}

I assume that we gonna have a button on the list view and show view we gonna use the create form prefilled with the item that selected.
image
image

@mik-laj
Copy link
Member

mik-laj commented Nov 23, 2020

I think, you can use can_create perm.

@vikramkoka vikramkoka added the area:UI Related to UI/UX. For Frontend Developers. label Mar 24, 2021
@pateash
Copy link
Contributor

pateash commented Apr 28, 2021

I am working on this.
@mik-laj could you please assign this to me.

@pateash
Copy link
Contributor

pateash commented May 11, 2021

Implemented, multi-select and duplication.

@ashb ashb added this to the Airflow 2.2 milestone Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues good first issue kind:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants