Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/enforce ESLint (JavaScript linting) in pre-commit hooks #14154

Closed
ryanahamilton opened this issue Feb 9, 2021 · 0 comments · Fixed by #15858
Closed

Add/enforce ESLint (JavaScript linting) in pre-commit hooks #14154

ryanahamilton opened this issue Feb 9, 2021 · 0 comments · Fixed by #15858
Assignees
@bbovenzi
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:task A task that needs to be completed as part of a larger issue type:improvement Changelog: Improvements

Comments

@ryanahamilton
Copy link
Contributor

There is already an existing ESLint configuration and supporting yarn lint commands, it just needs to be integrated into pre-commit.

This will prevent errors and ensure consistent style/syntax is utilized throughout the codebase.

I made a previous attempt at resolving it several months ago in #11699. While I had it working locally, I was unable to get it executing properly in our CI environment.

Related Issues

We're working on migrating our inline JavaScript to external files (#14115). I'm not sure that is a pre-requisite for this issue, but the order of execution will certainly affect the scope.
@ryanahamilton ryanahamilton added area:webserver Webserver related Issues type:improvement Changelog: Improvements area:UI Related to UI/UX. For Frontend Developers. labels Feb 9, 2021
@vikramkoka vikramkoka added the kind:task A task that needs to be completed as part of a larger issue label Feb 9, 2021
@yuqian90 yuqian90 mentioned this issue Mar 12, 2021
Merged
@bbovenzi bbovenzi self-assigned this Apr 13, 2021
@bbovenzi bbovenzi mentioned this issue May 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbovenzi bbovenzi

Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:task A task that needs to be completed as part of a larger issue type:improvement Changelog: Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce js linting for current ui in pre-commit astronomer/airflow
3 participants
@ryanahamilton @bbovenzi @vikramkoka