Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataflowStartFlexTemplateOperator is missing the impersonation_chain argument #22306

Closed
1 of 2 tasks
hadoken69 opened this issue Mar 16, 2022 · 6 comments
Closed
1 of 2 tasks

DataflowStartFlexTemplateOperator is missing the impersonation_chain argument #22306

hadoken69 opened this issue Mar 16, 2022 · 6 comments
Labels
contributors-workshop Issues that are good for first-time contributor's workshop good first issue kind:feature Feature Requests provider:google Google (including GCP) related issues

Comments

@hadoken69
Copy link

Description

The DataflowStartFlexTemplateOperator operator (https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/operators/dataflow.py) don't have the impersonation_chain argument even though the dataflow hook accept it in its argument (https://github.com/apache/airflow/blob/main/airflow/providers/google/cloud/operators/dataflow.py)

Use case/motivation

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@hadoken69 hadoken69 added the kind:feature Feature Requests label Mar 16, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 16, 2022

Thanks for opening your first issue here! Be sure to follow the issue template!

@potiuk potiuk added good first issue provider:google Google (including GCP) related issues labels Mar 16, 2022
@mik-laj
Copy link
Member

mik-laj commented Mar 16, 2022 •
edited
Loading

We should make similar change to:
#19518 (comment) (CC: @lwyszomi )

@eladkal eladkal added the contributors-workshop Issues that are good for first-time contributor's workshop label May 26, 2022
@kevgeo
Copy link
Contributor

kevgeo commented May 31, 2022 •
edited
Loading

Hi @eladkal, @mik-laj, I would love to take up this issue.

@mik-laj
Copy link
Member

mik-laj commented May 31, 2022

@kevgeo Assigned!

@lwyszomi
Copy link
Contributor

@kevgeo @eladkal @mik-laj I already implemented this changes in my local env and I'm testing that everything works correctly, I should sent PR today

@lwyszomi lwyszomi mentioned this issue May 31, 2022
Merged
@sotnich
Copy link

sotnich commented Dec 26, 2022

Should this issue be closed? As @lwyszomi already merged the changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributors-workshop Issues that are good for first-time contributor's workshop good first issue kind:feature Feature Requests provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@lwyszomi @potiuk @uranusjr @sotnich @kevgeo @mik-laj @hadoken69 @eladkal