Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pause/unpause dag logs wrong event status #31871

Closed
2 tasks done
achharKalia opened this issue Jun 13, 2023 · 10 comments
Closed
2 tasks done

pause/unpause dag logs wrong event status #31871

achharKalia opened this issue Jun 13, 2023 · 10 comments
Labels
affected_version:main_branch Issues Reported for main branch area:core good first issue kind:bug This is a clearly a bug

Comments

@achharKalia
Copy link

Apache Airflow version

Other Airflow 2 version (please specify below)

What happened

IN version 2.5.1 release, airflow pause/unpause dag button on dags page doesn't work properly.
When we pause a dag in the audit logs its show dag as unpaused.
and when we unpause any dag audit log shows a dag is paused. Also sometimes dag runs properly as per schedule and sometime doesn't because of this problem.

IN recent dag behaviour, we enabled the dag on friday and dag was scheduled to run on Monday but it didn't. It was a active dag not paused in blue color. However in the dag audit logs, it was showing below :

2023-06-12, 17:42:57 None paused None achhar.kalia [('is_paused', 'false'), ('dag_id', 'resdex-usage-mis-w')]
2023-06-08, 17:53:02 None paused None pawan.shaw@naukri.com [('is_paused', 'true'), ('dag_id', 'resdex-usage-mis-w')]

image

What you think should happen instead

when we pause, it should say its paused, when we unpause or resume, it should give message that dag is in unpause or resume state.

How to reproduce

try, for me this is still live problem in 2.5.1

Operating System

centos 7

Versions of Apache Airflow Providers

No response

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@achharKalia achharKalia added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Jun 13, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 13, 2023

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@achharKalia
Copy link
Author

hi, ANy update on the issue,

@utkarsharma2
Copy link
Contributor

utkarsharma2 commented Jun 15, 2023

Since you checked in Are you willing to submit PR? section, I assumed you wanted to open a PR for the issue :)

@achharKalia
Copy link
Author

yes, I want to open PR.

@potiuk
Copy link
Member

potiuk commented Jun 16, 2023

Assigned you then :)

@achharKalia
Copy link
Author

any luck you are able to find.

@gustavohwulee
Copy link

not sure if this is related but in this version 2.5.1 when we try to pause a dag programatically the value is not logged to the audit logs if it runs by the scheduler.

@vincbeck vincbeck removed the needs-triage label for new issues that we didn't triage yet label Jul 18, 2023
@eladkal eladkal changed the title airflow pause/unpause dag button on dags doesn't work properly, when we pause audit logs show its unpaused and whwen we unpause audit log shows pause pause/unpause dag logs wrong event status Aug 5, 2023
@eladkal
Copy link
Contributor

eladkal commented Aug 5, 2023

Able to reproduce this on main branch

@alephmelo
Copy link
Contributor

@eladkal Would you be able to review the PR I opened a few days ago? 🙏

@eladkal
Copy link
Contributor

eladkal commented Dec 17, 2023

Solved in #36182

@eladkal eladkal closed this as completed Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:main_branch Issues Reported for main branch area:core good first issue kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants