Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git Sync 4 support #32335

Closed
1 task done
potiuk opened this issue Jul 3, 2023 · 6 comments · Fixed by #34731
Closed
1 task done

Git Sync 4 support #32335

potiuk opened this issue Jul 3, 2023 · 6 comments · Fixed by #34731
Assignees
@Swalloow
Labels
area:helm-chart Airflow Helm Chart good first issue kind:meta High-level information important to the community

Comments

@potiuk
Copy link
Member

potiuk commented Jul 3, 2023 •
edited
Loading

Body

Git Sync 4 - about to be released- introduces a lot of changes (including changed names for env variables).That heavily impacts our Helm Chart and we should fix those incompatiblities before the next release

Info about the changes here: https://github.com/kubernetes/git-sync/releases/tag/v4.0.0-rc2

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@potiuk potiuk added the kind:meta High-level information important to the community label Jul 3, 2023
@potiuk
Copy link
Member Author

potiuk commented Jul 3, 2023

cc: @jedcunningham @dstandish @ephraimbuddy

@potiuk
Copy link
Member Author

potiuk commented Jul 3, 2023

FYI: Our chart variables - for one - are completely not working (for example GIT_SYNC_WAIT -> GITSYNC_PERIOD.

@eladkal eladkal mentioned this issue Aug 25, 2023
Merged
@Swalloow
Copy link
Contributor

Is anyone assigned? If not, I will do it.

@mnacharov mnacharov mentioned this issue Sep 13, 2023
Closed
@Swalloow Swalloow mentioned this issue Oct 3, 2023
Merged
@bakome
Copy link

bakome commented Oct 11, 2023

I was able to implement git-sync v4 but faced interesting problem there. I also open a PR on git-sync because I think airflow instances can be heavily impacted by this weird behavior. In my case it was implementation with NFS, but this bug can be repeated with other implementations.

kubernetes/git-sync#827

@potiuk
Copy link
Member Author

potiuk commented Oct 12, 2023

kubernetes/git-sync#827

Interesting. I see you proposed a fix (cool!)

@eladkal
Copy link
Contributor

eladkal commented Oct 24, 2023

v4.1.0 is released with the fix of kubernetes/git-sync#828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Swalloow Swalloow

Labels
area:helm-chart Airflow Helm Chart good first issue kind:meta High-level information important to the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support git-sync v4 in Helm Chart Swalloow/airflow
Chart: added basic support git-sync v4.0.0+
4 participants
@potiuk @Swalloow @bakome @eladkal