Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to the task log #33625

Open
1 task done
eladkal opened this issue Aug 22, 2023 · 4 comments
Open
1 task done

Add pagination to the task log #33625

eladkal opened this issue Aug 22, 2023 · 4 comments
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests

Comments

@eladkal
Copy link
Contributor

eladkal commented Aug 22, 2023

Body

We had issue with larger log #29390 that was blocked by adding pagination support to the Rest API #29405

Now that Rest API supports pagination we can apply it to the UI.

cc @bbovenzi (following our discussion)

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added kind:feature Feature Requests good first issue area:UI Related to UI/UX. For Frontend Developers. labels Aug 22, 2023
@erdos2n
Copy link
Contributor

erdos2n commented Aug 23, 2023

@eladkal can I pick this up?

@eladkal
Copy link
Contributor Author

eladkal commented Aug 24, 2023

@eladkal can I pick this up?

Assigned

@erdos2n erdos2n removed their assignment Sep 8, 2023
@erdos2n
Copy link
Contributor

erdos2n commented Sep 8, 2023

Had a session with @bbovenzi and am unassigning myself. Issue is a bit out of my depth.

@bbovenzi
Copy link
Contributor

bbovenzi commented Sep 8, 2023

After looking through it again, we really should deserialize the continuation_token in the API and just pas log_pos and end_of_log as real parameters. Otherwise the API client needs to know the serializing key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests
Projects
None yet
Development

No branches or pull requests

3 participants