Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Grid error when DAG has been removed #34058

Closed
pierrejeambrun opened this issue Sep 3, 2023 Discussed in #33817 · 7 comments · Fixed by #36028
Closed

UI Grid error when DAG has been removed #34058

pierrejeambrun opened this issue Sep 3, 2023 Discussed in #33817 · 7 comments · Fixed by #36028
Labels
affected_version:main_branch Issues Reported for main branch area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug
Milestone

Comments

@pierrejeambrun
Copy link
Member

Reproduce on main:

  • Run a DAG
  • Rename the DAG
  • Wait for dag file processor to remove the deleted DAG and add the new one. (Old Dag should not appear on the home page anymore)
  • Go to the Browse DAGRUN page.
  • Click on a DagRun of the deleted DAG, as if you want to see the 'details/grid' of that old dag run

More info and screenshots here:
https://github.com/notifications#discussioncomment-6898570

image

@pierrejeambrun pierrejeambrun changed the title Grid issues when Dag has been removed Grid error when Dag has been removed Sep 3, 2023
@pierrejeambrun pierrejeambrun added area:UI Related to UI/UX. For Frontend Developers. type:bug-fix Changelog: Bug Fixes kind:bug This is a clearly a bug and removed type:bug-fix Changelog: Bug Fixes labels Sep 3, 2023
@pierrejeambrun pierrejeambrun added this to the Airflow 2.7.2 milestone Sep 3, 2023
@pierrejeambrun pierrejeambrun changed the title Grid error when Dag has been removed UI Grid error when DAG has been removed Sep 3, 2023
@eladkal eladkal added the affected_version:main_branch Issues Reported for main branch label Sep 3, 2023
@Abhishek-kumar-samsung
Copy link
Contributor

Hi @pierrejeambrun ,
when i click on details of deleted dag then the following comes

107 99 45 216_28080_dags_hello_world1_graph_execution_date=2023-09-03+12%3A00%3A00%2B00%3A00

Not sure it is some problem with my local setup or something else, but i am not able to reproduce

@pierrejeambrun
Copy link
Member Author

Did you run it with breeze ? Or ran the webserver in debug mode ?

We see that there is an error, you just don’t have the stack trace, meaning that the server is not in debug mode.

Having an error is not expected.

@potiuk
Copy link
Member

potiuk commented Sep 6, 2023

Yes. As mentioned in the first line of what you should do "gather the relevant information (detailed log with errors...".

You need to look there. Exposing more information in the UI is a potential security issue. No application in produciton mode should EVER do that.

@Abhishek-kumar-samsung
Copy link
Contributor

Did you run it with breeze ? Or ran the webserver in debug mode ?

We see that there is an error, you just don’t have the stack trace, meaning that the server is not in debug mode.

Having an error is not expected.

I ran using breeze start-airflow, it won't occur there?

@Abhishek-kumar-samsung
Copy link
Contributor

Yes. As mentioned in the first line of what you should do "gather the relevant information (detailed log with errors...".

You need to look there. Exposing more information in the UI is a potential security issue. No application in produciton mode should EVER do that.

Oh okay.

@potiuk
Copy link
Member

potiuk commented Sep 7, 2023

I ran using breeze start-airflow, it won't occur there?

You can add --dev-mode flag when you run start-airflow - then instead of the "ooops" screen you will see the screen that @pierrejeambrun posted above - with more details and debugging capabilities

@Abhishek-kumar-samsung
Copy link
Contributor

I ran using breeze start-airflow, it won't occur there?

You can add --dev-mode flag when you run start-airflow - then instead of the "ooops" screen you will see the screen that @pierrejeambrun posted above - with more details and debugging capabilities

Thankyou
Now i am able to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:main_branch Issues Reported for main branch area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants