Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Helm chart dependency to bitnami/postgresql 13.x.x and PostgreSQL 16 #34817

Closed
2 tasks done
dnskr opened this issue Oct 7, 2023 · 6 comments · Fixed by #36156
Closed
2 tasks done

Upgrade Helm chart dependency to bitnami/postgresql 13.x.x and PostgreSQL 16 #34817

dnskr opened this issue Oct 7, 2023 · 6 comments · Fixed by #36156
Labels
area:helm-chart Airflow Helm Chart good first issue type:improvement Changelog: Improvements

Comments

@dnskr
Copy link
Contributor

dnskr commented Oct 7, 2023

Official Helm Chart version

1.11.0 (latest released)

Apache Airflow version

2.7.1

Kubernetes Version

1.27

Helm Chart configuration

No response

Docker Image customizations

No response

What happened

Airflow Helm chart 1.11.0 depends on bitnami/postgresql:12.10.0 subchart and deploys PostgreSQL 11 by default.

Apart from good practice of keeping dependencies up to date, there is an end-of-life for PostgreSQL 11 coming in November 9, 2023 as described in PostgreSQL Versioning Policy.

What you think should happen instead

Next Airflow Helm chart release should use latest bitnami/postgresql:13.x.x and PostgreSQL 16 by default.

How to reproduce

Deploy Airflow Helm chart 1.11.0 with default configuration.

Anything else

This issue is created to highlight the problem and discuss how it should be fixed with minimal impact on end users.

PostgreSQL was intentionally downgraded from 15 to 11 after bitnami/postgresql upgrade from 10.5.3 to 12.1.9.
Related PRs:

The PR #29207 also contains the discussion of future version upgrade.

Also related PRs with minor changes and fixes:

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@dnskr dnskr added area:helm-chart Airflow Helm Chart kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Oct 7, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 7, 2023

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@Taragolis
Copy link
Contributor

and PostgreSQL 16 by default.

This would unlikely happen, Airflow CI do not have regular runs on Postgres 16 yet (#34543)

After EOL Postgres 11 I guess default would be Postgres 12, at least this happen for other components: default python is 3.8, default db backend the oldest one.

@dnskr
Copy link
Contributor Author

dnskr commented Oct 8, 2023

Airflow Helm chart has been released recently, so taking it into considiration, there is a good chance that Airflow can support Postgres 16 officially before next Helm chart release.
I'm fine with upgrading PostgreSQL to the newest possible version, either it's 15, 14, 13 or even 12. However, I'm not sure that upgrading to PostgreSQL 12 is a pragmatic solution, because end-of-life for PostgreSQL 12 coming next year (November 14, 2024).

Main challenge with the upgrade is that there is no auto-upgrade options for major versions of PostgreSQL as far as I know, i.e. major version upgrade flow requires users to manage it manually with some database downtime. See https://www.postgresql.org/docs/current/pgupgrade.html for more details.

@jscheffl jscheffl added type:improvement Changelog: Improvements and removed kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Oct 8, 2023
@eladkal
Copy link
Contributor

eladkal commented Oct 17, 2023

We added Postgres 16 support to main branch #34543

@dnskr
Copy link
Contributor Author

dnskr commented Dec 6, 2023

Looks like there is no automated solution for the problem at the moment.
Related issue bitnami/charts#14926

@potiuk
Copy link
Member

potiuk commented Dec 7, 2023

We can continue upgrading it manually as we do now. And it's fine to upgrade to postgres 16 immediately. Postgres in our chart is not intended for production use and you SHOULD use external postgres. So we do not have to maintain any compatibility or upgrade path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart good first issue type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants