Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid to use sync (with blocking io) functions into the WorkflowTrigger #38672

Closed
1 task done
Taragolis opened this issue Apr 2, 2024 · 1 comment · Fixed by #38689
Closed
1 task done

Avoid to use sync (with blocking io) functions into the WorkflowTrigger #38672

Taragolis opened this issue Apr 2, 2024 · 1 comment · Fixed by #38689
Assignees
@stevenschaerer
Labels
affected_version:main_branch Issues Reported for main branch area:core good first issue kind:meta High-level information important to the community

Comments

@Taragolis
Copy link
Contributor

Body

After last refactoring (#36916) airflow.triggers.external_task.WorkflowTrigger start more actively use blocking IO - request to DB with non-async drivers.

Instead of direct call sync method, it should be wrapped in one of the common practice to run sync code into async loop:

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@Taragolis Taragolis added kind:meta High-level information important to the community area:core affected_version:main_branch Issues Reported for main branch good first issue labels Apr 2, 2024
@stevenschaerer
Copy link
Contributor

stevenschaerer commented Apr 2, 2024 •
edited
Loading

Happy to take a look.

@stevenschaerer stevenschaerer mentioned this issue Apr 2, 2024
Merged
@ephraimbuddy ephraimbuddy mentioned this issue Apr 30, 2024
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenschaerer stevenschaerer

Labels
affected_version:main_branch Issues Reported for main branch area:core good first issue kind:meta High-level information important to the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use async db calls in WorkflowTrigger stevenschaerer/airflow
2 participants
@Taragolis @stevenschaerer