Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DB migration tests in CI #38744

Open
1 task done
potiuk opened this issue Apr 4, 2024 · 1 comment
Open
1 task done

Improve DB migration tests in CI #38744

potiuk opened this issue Apr 4, 2024 · 1 comment
Labels
kind:meta High-level information important to the community

Comments

@potiuk
Copy link
Member

potiuk commented Apr 4, 2024

Body

Our DB migration tests in CI run on empty tables and some of the migrations perform some data manipulation during down/up migration. By having empty tables we are skipping over this logic.

We should likely add some steps before and in-between the migration to populate the database witth data - likely by running a few dags maybe runniing a few other commands that modify the data (connections/variables etc.).

Also, it seems that some of the migrations might behave differently depending on what is the "to" migration - for example in case of 2.9.0 -> 2.8.4 migration, the original migration in #38743 failed, while 2.0.0 did not and we have to either change our CI testing or (I'd say more likely) make it a bit more "Target independent"

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@potiuk potiuk added the kind:meta High-level information important to the community label Apr 4, 2024
@potiuk
Copy link
Member Author

potiuk commented Apr 4, 2024

cc: @ephraimbuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community
Projects
None yet
Development

No branches or pull requests

1 participant