Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes "name" and "group" to Asset class #42310

Closed
2 tasks done
Lee-W opened this issue Sep 18, 2024 · 5 comments
Closed
2 tasks done

Add attributes "name" and "group" to Asset class #42310

Lee-W opened this issue Sep 18, 2024 · 5 comments
Assignees
Labels
AIP-74 Dataset -> Asset area:datasets Issues related to the datasets feature kind:feature Feature Requests

Comments

@Lee-W
Copy link
Member

Lee-W commented Sep 18, 2024

Description

The Asset Class

Use case/motivation

Rationale

Related issues

#42307

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Lee-W Lee-W added kind:feature Feature Requests AIP-74 Dataset -> Asset labels Sep 18, 2024
@Lee-W Lee-W added the area:datasets Issues related to the datasets feature label Sep 19, 2024
@uranusjr
Copy link
Member

First PR published on the database end. #42407

@uranusjr
Copy link
Member

Database changes are done. Next I’m going to add the two arguments to the public-facing Asset class so the user can pass them to be stored in the database.

There’s one thing we need to address in the database after we do the above. Since we want to keep history in the asset table, we need to have the unique constraint on (name, uri) so a name can be reused by different assets as long as the URIs are different, vice versa. But we still want only one active asset to use that name. So I’ll add a separate table to only keep track of active (non-orphaned) assets so we can add all those unique constraints appropriately.

@uranusjr
Copy link
Member

uranusjr commented Oct 8, 2024

PR to add database-level uniqu constraint (see previous message)
#42612

(Draft) Main change to add name and group to Asset (tests tbd)
#42812

(Draft) Tweak AssetAlias to match Asset (not strictly a part of AIP-73 but should be a good thing)
#42814

@uranusjr
Copy link
Member

Both name and group have been added to Asset, and they are stored on AssetModel.

#42814 is a related PR to also add group to AssetAlias, and change name constraints to match Asset, but not a strict blocker.

@uranusjr
Copy link
Member

I think we’re done here!

@github-project-automation github-project-automation bot moved this from In progress to Done in AIP-74 Introducing Data Assets Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-74 Dataset -> Asset area:datasets Issues related to the datasets feature kind:feature Feature Requests
Projects
Development

No branches or pull requests

2 participants