Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-68 | Migrate plugin menu_items to FastAPI and new UI #42706

Closed
bbovenzi opened this issue Oct 3, 2024 · 7 comments
Closed

AIP-68 | Migrate plugin menu_items to FastAPI and new UI #42706

bbovenzi opened this issue Oct 3, 2024 · 7 comments
Assignees
Labels
AIP-68 Extended Plugin Interface for React Views AIP-84 Modern Rest API area:API Airflow's REST/HTTP API area:plugins area:UI Related to UI/UX. For Frontend Developers.

Comments

@bbovenzi
Copy link
Contributor

bbovenzi commented Oct 3, 2024

@bbovenzi bbovenzi converted this from a draft issue Oct 3, 2024
@bbovenzi bbovenzi changed the title Expose plugin menu_items to FastAPI and new UI Migrate plugin menu_items to FastAPI and new UI Oct 3, 2024
@bbovenzi bbovenzi added the AIP-68 Extended Plugin Interface for React Views label Oct 3, 2024
@dosubot dosubot bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Oct 3, 2024
@Brijeshthummar02
Copy link

@bbovenzi i can fix this, assign me the task.

@bbovenzi
Copy link
Contributor Author

bbovenzi commented Oct 3, 2024

@Brijeshthummar02 assigned! Let me know if you need help with any part here.

@bbovenzi bbovenzi changed the title Migrate plugin menu_items to FastAPI and new UI AIP-68 | Migrate plugin menu_items to FastAPI and new UI Oct 3, 2024
@Brijeshthummar02
Copy link

Guide me for 2nd and 3rd point,can you clarify in brief with the path.

@bbovenzi
Copy link
Contributor Author

bbovenzi commented Oct 4, 2024

  1. just rename the plugin menu_items property
  2. create a new GET /plugins endpoint in the new FastAPI that will return a list of all plugin menu_items. You can the PRs tagged here to see how to build endpoints for FastAPI: AIP-84 Migrate public endpoints from api_connexion to the new Rest API #42370
  3. Once there is an endpoint in FastAPI, we autogenerate all the types and queries. Then you call the function, something like usePluginServiceGetPlugins(), inside the Nav component to render the MenuItems. Probably reusing the code from the DocsButton component.

@Brijeshthummar02
Copy link

can you provide the path of file for the first point.

@bbovenzi
Copy link
Contributor Author

bbovenzi commented Oct 7, 2024

Actually, let's focus on point 2. Renaming can be handled later.

@bbovenzi
Copy link
Contributor Author

Actually we have the menu items provided in #43125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-68 Extended Plugin Interface for React Views AIP-84 Modern Rest API area:API Airflow's REST/HTTP API area:plugins area:UI Related to UI/UX. For Frontend Developers.
Projects
Development

No branches or pull requests

2 participants