Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-38 | DAGs List | Search by dag_display_name_pattern #42714

Closed
bbovenzi opened this issue Oct 3, 2024 · 2 comments
Closed

AIP-38 | DAGs List | Search by dag_display_name_pattern #42714

bbovenzi opened this issue Oct 3, 2024 · 2 comments
Assignees
@luyangliuable
Labels
AIP-38 Modern Web Application area:UI Related to UI/UX. For Frontend Developers. good first issue kind:feature Feature Requests

Comments

@bbovenzi
Copy link
Contributor

bbovenzi commented Oct 3, 2024 •
edited
Loading

The public get dags endpoints in FastAPI now supports dag_display_name_pattern. We should use that to search DAGs in the UI and activate the disabled search bar that is already there.

We can leave "Advanced Search" disabled for now.

See top of page for the search bar:
Image
@bbovenzi bbovenzi converted this from a draft issue Oct 3, 2024
@bbovenzi bbovenzi added good first issue area:UI Related to UI/UX. For Frontend Developers. AIP-38 Modern Web Application kind:feature Feature Requests labels Oct 3, 2024
@bbovenzi bbovenzi changed the title Add ability to search DAGs list by dag_display_name_pattern DAGs List: Add ability to search by dag_display_name_pattern Oct 3, 2024
@bbovenzi bbovenzi changed the title DAGs List: Add ability to search by dag_display_name_pattern AIP-38 | DAGs List | Search by dag_display_name_pattern Oct 3, 2024
@luyangliuable luyangliuable mentioned this issue Oct 7, 2024
Closed
@bbovenzi bbovenzi mentioned this issue Oct 10, 2024
Merged
@luyangliuable
Copy link
Contributor

Hi I was just wondering is this issue ready to be closed or is there anything more that needs to be fixed :)

@bbovenzi
Copy link
Contributor Author

Closed via #42896

@bbovenzi bbovenzi mentioned this issue Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luyangliuable luyangliuable

Labels
AIP-38 Modern Web Application area:UI Related to UI/UX. For Frontend Developers. good first issue kind:feature Feature Requests
Projects
AIP-38: Modern Web Application
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbovenzi @luyangliuable