-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-38 | Add colorblind friendly color schemes #43054
Comments
❤️ |
We have 12 state colors right now, which is a lot, and leaves us with three options:
In all scenarios, we should always try to depict state through other means than simply color. |
Possible groupings with the same color but some indication that they're separate: Pre run: queued, schedule, deferred |
I think queued and scheduled are distinct enough to need different colors. And skipped /upstream_failedcould be the same colour, but I don't think no_status/null should be in the same grouping. One has never been, the other ran and failed. Removed I could se go in either side. |
In general - great idea and kudos for making the UI more accessible for those in need! My two cents regarding your suggestions:
+ Don't forget the dark mode :) |
|
FYI Animation is also against guidelines for accessibility - we had issue about it #34019 |
We could also let the user pick their own colors for each state. |
Yes, we do allow |
We are starting to add status colors to the new UI. Before we build out too much we should make sure to think about a11y from the get go. A lot of status colors are hard for people (particularly red/green).
Update our theme to always use semantic names instead of colors (ex: "error" instead of "red", "success" instead of "green)
Decide to use a colorblind friendly color palette for everyone, or add a user setting to switch between common semantic colors and a friendlier palette
The text was updated successfully, but these errors were encountered: