Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto template format detection #44255

Open
1 task done
uranusjr opened this issue Nov 21, 2024 · 0 comments
Open
1 task done

Remove auto template format detection #44255

uranusjr opened this issue Nov 21, 2024 · 0 comments
Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes airflow3.0:candidate Potential candidates for Airflow 3.0 area:db-migrations PRs with DB migration area:logging

Comments

@uranusjr
Copy link
Member

Body

Currently we do some “smart” (in quotes because it’s not actually very smart) detection whether a log template uses Python format string (e.g. {foo}-{bar}) or Jinja2 template syntax. We should find a way to remove the former as a feature and just always use Jinja2.

(Below is copied from another discussion)

The problem is we do record the log file template on DagRun so we could find the correct logs for an old run. Either we somehow find a way to distinguish those old runs (add a flag in db?) or we need to convert those old template strings into Jinja format in a db migration.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@uranusjr uranusjr added airflow3.0:candidate Potential candidates for Airflow 3.0 airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes labels Nov 21, 2024
@dosubot dosubot bot added area:db-migrations PRs with DB migration area:logging labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes airflow3.0:candidate Potential candidates for Airflow 3.0 area:db-migrations PRs with DB migration area:logging
Projects
None yet
Development

No branches or pull requests

1 participant