-
Notifications
You must be signed in to change notification settings - Fork 16.4k
docs: clarify AssetAlias usage with detailed explanation and examples #52259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3af3ead
docs: update public interface doc to reflect airflow.sdk and AIP-72
nrnavaneet ff3d500
Merge branch 'main' into update-public-interface-docs
nrnavaneet 0538d94
Update airflow-core/docs/public-airflow-interface.rst
nrnavaneet 8aef705
Merge branch 'main' into improve-assetalias-docs
nrnavaneet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,21 @@ and for automating certain aspects of the Airflow workflow. | |
| Using Airflow Public Interfaces | ||
| =============================== | ||
|
|
||
| .. note:: | ||
|
|
||
| As of **Airflow 3.0**, users should use the ``airflow.sdk`` namespace as the official **Public Interface**, as defined in `AIP-72 <https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-72+Task+Execution+Interface+aka+Task+SDK>`_. | ||
|
|
||
| Direct interaction with internal modules or the metadata database is not possible. | ||
| For stable, production-safe integration, it is recommended to use: | ||
|
|
||
| - The official **REST API** | ||
| - The **Python Client SDK** (`airflow-client-python`) | ||
| - The new **Task SDK** (``airflow.sdk``) | ||
|
|
||
| Related docs: | ||
| - `Release Notes 3.0 <https://airflow.apache.org/docs/apache-airflow/stable/release_notes.html>`_ | ||
| - `Task SDK Overview <https://airflow.apache.org/docs/apache-airflow/stable/concepts/taskflow.html>`_ | ||
|
Comment on lines
+43
to
+44
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be relative links rather than http ones. We use http only for external resources |
||
|
|
||
| The following are some examples of the public interface of Airflow: | ||
|
|
||
| * When you are writing your own operators or hooks. This is commonly done when no hook or operator exists for your use case, or when perhaps when one exists but you need to customize the behavior. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the motivation to mention AIP-72? Generally speaking AIP numbering is internal information of Airflow developers they are not so meaningful to users (we do mention them sometimes but mostly for future plans not as reference to completed work)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire file is also being reworked as part of #52297 by @sunank200
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah cool
so if it suppress this PR lets close it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea