Skip to content

[v3-0-test] fix(UI): Correct illegible DAG params text in dark mode (#54245) #54260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Aug 10, 2025
Merged

[v3-0-test] fix(UI): Correct illegible DAG params text in dark mode (#54245) #54260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions airflow-core/src/airflow/ui/src/components/RenderedJsonField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
* under the License.
*/
import { Flex, type FlexProps } from "@chakra-ui/react";
import { useTheme } from "next-themes";
import ReactJson, { type ReactJsonViewProps } from "react-json-view";

import { ClipboardRoot, ClipboardIconButton } from "src/components/ui";
import { useColorMode } from "src/context/colorMode";

type Props = {
readonly content: object;
Expand All @@ -29,7 +29,7 @@ type Props = {

const RenderedJsonField = ({ content, jsonProps, ...rest }: Props) => {
const contentFormatted = JSON.stringify(content, undefined, 4);
const { theme } = useTheme();
const { colorMode } = useColorMode();

return (
<Flex {...rest}>
Expand All @@ -43,7 +43,7 @@ const RenderedJsonField = ({ content, jsonProps, ...rest }: Props) => {
style={{
backgroundColor: "inherit",
}}
theme={theme === "dark" ? "monokai" : "rjv-default"}
theme={colorMode === "dark" ? "monokai" : "rjv-default"}
{...jsonProps}
/>
<ClipboardRoot value={contentFormatted}>
Expand Down
Loading