Skip to content

Enable PT011 rule to prvoider tests #56277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 11 commits into from
Oct 1, 2025
Merged

Enable PT011 rule to prvoider tests #56277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fe3efea
modify test_ftp
xchwan Oct 1, 2025
dcf1f9f
modify test_sql
xchwan Oct 1, 2025
6428dc1
modify test_exasol
xchwan Oct 1, 2025
219d6fa
modify test_es_task_handler
xchwan Oct 1, 2025
38bfe86
modify test_edge_executor
xchwan Oct 1, 2025
89a6ccf
fix test_edge_executor match
xchwan Oct 1, 2025
f1c2839
fix test_edge_executor match
xchwan Oct 1, 2025
b79f0f8
fix test_edge_executor match
xchwan Oct 1, 2025
3da6c7f
Merge branch 'main' into enable_PT011_rule_9
xchwan Oct 1, 2025
2b3a6e7
Merge branch 'main' into enable_PT011_rule_9
xchwan Oct 1, 2025
b3b0a46
Merge branch 'main' into enable_PT011_rule_9
xchwan Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions providers/edge3/tests/unit/edge3/executors/test_edge_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@
from airflow.providers.edge3.executors.edge_executor import EdgeExecutor
from airflow.providers.edge3.models.edge_job import EdgeJobModel
from airflow.providers.edge3.models.edge_worker import EdgeWorkerModel, EdgeWorkerState
from airflow.utils import timezone

try:
from airflow.sdk import timezone
except ImportError:
from airflow.utils import timezone # type: ignore[attr-defined,no-redef]
from airflow.utils.session import create_session
from airflow.utils.state import TaskInstanceState

Expand Down Expand Up @@ -62,7 +66,7 @@ def get_test_executor(self, pool_slots=1):
def test__process_tasks_bad_command(self):
executor, key = self.get_test_executor()
task_tuple = (key, ["hello", "world"], None, None)
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="The command must start with "):
executor._process_tasks([task_tuple])

@pytest.mark.skipif(AIRFLOW_V_3_0_PLUS, reason="_process_tasks is not used in Airflow 3.0+")
Expand Down
2 changes: 1 addition & 1 deletion providers/elasticsearch/tests/unit/elasticsearch/log/test_es_task_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def test_format_url(self, host, expected):
Test the format_url method of the ElasticsearchTaskHandler class.
"""
if expected == "ValueError":
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="'https://' is not a valid URL."):
assert ElasticsearchTaskHandler.format_url(host) == expected
else:
assert ElasticsearchTaskHandler.format_url(host) == expected
Expand Down
5 changes: 2 additions & 3 deletions providers/exasol/tests/unit/exasol/hooks/test_exasol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def test_sqlalchemy_scheme_property(self, init_scheme, extra_scheme, expected_re
if not expect_error:
assert hook.sqlalchemy_scheme == expected_result
else:
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="sqlalchemy_scheme in connection extra should be one of"):
_ = hook.sqlalchemy_scheme

@pytest.mark.parametrize(
Expand Down Expand Up @@ -213,9 +213,8 @@ def test_run_multi_queries(self):
self.conn.commit.assert_not_called()

def test_run_no_queries(self):
with pytest.raises(ValueError) as err:
with pytest.raises(ValueError, match="List of SQL statements is empty"):
self.db_hook.run(sql=[])
assert err.value.args[0] == "List of SQL statements is empty"

def test_no_result_set(self):
"""Queries like DROP and SELECT are of type rowCount (not resultSet),
Expand Down
3 changes: 1 addition & 2 deletions providers/exasol/tests/unit/exasol/hooks/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,5 @@ def test_query(
def test_no_query(empty_statement):
dbapi_hook = ExasolHookForTests()
dbapi_hook.get_conn.return_value.cursor.rowcount = lambda: 0
with pytest.raises(ValueError) as err:
with pytest.raises(ValueError, match="List of SQL statements is empty"):
dbapi_hook.run(sql=empty_statement)
assert err.value.args[0] == "List of SQL statements is empty"
4 changes: 2 additions & 2 deletions providers/ftp/tests/unit/ftp/operators/test_ftp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,15 @@ def test_arg_checking(self, mock_put):
task_1.execute(None)

def test_unequal_local_remote_file_paths(self):
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="1 paths in local_filepath != 2 paths in remote_filepath"):
FTPFileTransmitOperator(
task_id="test_ftp_unequal_paths",
ftp_conn_id=DEFAULT_CONN_ID,
local_filepath="/tmp/test",
remote_filepath=["/tmp/test1", "/tmp/test2"],
).execute(None)

with pytest.raises(ValueError):
with pytest.raises(ValueError, match="2 paths in local_filepath != 1 paths in remote_filepath"):
FTPFileTransmitOperator(
task_id="test_ftp_unequal_paths",
ftp_conn_id=DEFAULT_CONN_ID,
Expand Down
Loading